Charm Helpers

Merge lp://staging/~freyes/charm-helpers/current-dc-none into lp://staging/charm-helpers

  1. current-dc-none
  2. Merge into devel
Proposed by Felipe Reyes
Status: Merged
Merged at revision: 385
Proposed branch: lp://staging/~freyes/charm-helpers/current-dc-none
Merge into: lp://staging/charm-helpers
Diff against target: 98 lines (+36/-6)
2 files modified
charmhelpers/contrib/hahelpers/cluster.py (+12/-3)
tests/contrib/hahelpers/test_cluster_utils.py (+24/-3)
To merge this branch: bzr merge lp://staging/~freyes/charm-helpers/current-dc-none
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+261273@code.staging.launchpad.net

Description of the change

Dear Charmers,

This patch improves charmhelpers.contrib.hahelpers.cluster:is_crm_dc() to consider the case when the current DC is NONE.

To allow the @retry_on_exception() decorator work when current DC is NONE or when 'crm status' fails the exception CRMDCNotFound is raised.

Best,

To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches