Merge ~freyes/+git/openstack-kpi-scripts:fix-reviewable into ~james-page/+git/openstack-kpi-scripts:master
Proposed by
Felipe Reyes
| Status: | Merged |
|---|---|
| Merged at revision: | e4d0952c53d978318cba41024cccf0f78ad928a9 |
| Proposed branch: | ~freyes/+git/openstack-kpi-scripts:fix-reviewable |
| Merge into: | ~james-page/+git/openstack-kpi-scripts:master |
| Diff against target: |
13 lines (+1/-1) 1 file modified
src/files/thirdparty/os-charm-reviews (+1/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Billy Olsen (community) | Approve | ||
| James Page | Pending | ||
|
Review via email:
|
|||
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I'll note that this technically does not restrict directly to zosci voting or not, it simply says there are 2 +1 verified. This is true for upstream CI + downstream CI currently, but if we add another 3rd party CI (e.g. storage driver CI), this may not be accurate/adequate any longer depending on the policies at the time.
However, for the time being, I think this looks reasonable.