Merge lp://staging/~free.ekanayaka/storm/schema-advance into lp://staging/storm
Proposed by
Free Ekanayaka
| Status: | Merged |
|---|---|
| Merged at revision: | 468 |
| Proposed branch: | lp://staging/~free.ekanayaka/storm/schema-advance |
| Merge into: | lp://staging/storm |
| Diff against target: |
641 lines (+336/-59) 6 files modified
storm/schema/patch.py (+108/-29) storm/schema/schema.py (+89/-20) storm/zope/testing.py (+2/-1) tests/schema/patch.py (+86/-7) tests/schema/schema.py (+49/-1) tests/zope/testing.py (+2/-1) |
| To merge this branch: | bzr merge lp://staging/~free.ekanayaka/storm/schema-advance |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Björn Tillenius (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Add a Schema.advance method that applies to the given store a certain patch version. This is useful for applying patches with the same number across a set of schemas.
To post a comment you must log in.
Revision history for this message
| Free Ekanayaka (free.ekanayaka) wrote | # |
Revision history for this message
| Björn Tillenius (bjornt) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for the changes. The new directory structure looks like a reasonable compromise. It makes it fairly easy to write patches for a single store only and it gives a good overview of which stores get patched.
It looks good in general, but I'm putting it in Needs Fixing, since some tests need to be enabled and rewritten.