Landscape Client

Merge lp://staging/~free.ekanayaka/landscape-client/mockify-lib-disk-tests into lp://staging/~landscape/landscape-client/trunk

  1. mockify-lib-disk-tests
  2. Merge into trunk
Proposed by Free Ekanayaka
Status: Merged
Approved by: Free Ekanayaka
Approved revision: 844
Merged at revision: 853
Proposed branch: lp://staging/~free.ekanayaka/landscape-client/mockify-lib-disk-tests
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 224 lines (+49/-56)
1 file modified
landscape/lib/tests/test_disk.py (+49/-56)
To merge this branch: bzr merge lp://staging/~free.ekanayaka/landscape-client/mockify-lib-disk-tests
Reviewer Review Type Date Requested Status
Chad Smith Approve
Chris Glass (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+297502@code.staging.launchpad.net

Commit message

Migrate landscape.lib.tests.test_disk from mocker to mock.

Description of the change

Migrate landscape.lib.tests.test_disk from mocker to mock.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Success
Revno: 843
Branch: lp:~free.ekanayaka/landscape-client/mockify-lib-disk-tests
Jenkins: https://ci.lscape.net/job/latch-test/5036/

review: Approve (test results)
Revision history for this message
Chris Glass (tribaal) wrote :

+1

review: Approve
Revision history for this message
Chad Smith (chad.smith) wrote :

+1. Let's tighten our mocks were possible. You can replace all cases s/assert_called_with(/assert_called_once_with(/

review: Approve
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

> +1. Let's tighten our mocks were possible. You can replace all cases
> s/assert_called_with(/assert_called_once_with(/

Fixed.

lp://staging/~free.ekanayaka/landscape-client/mockify-lib-disk-tests updated
844. By Free Ekanayaka

Address review comments

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: