Merge ~freddie-akeroyd/epics-base:nan_inf_tests into epics-base:7.0
Proposed by
Freddie Akeroyd
| Status: | Rejected |
|---|---|
| Rejected by: | mdavidsaver |
| Proposed branch: | ~freddie-akeroyd/epics-base:nan_inf_tests |
| Merge into: | epics-base:7.0 |
| Diff against target: |
127 lines (+28/-40) 2 files modified
modules/libcom/test/epicsCalcTest.cpp (+13/-14) modules/libcom/test/epicsMathTest.c (+15/-26) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrew Johnson | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Change tests to be more "a + -b" like than "a + -a" to avoid compiler optimisation issues
To post a comment you must log in.
Revision history for this message
| mdavidsaver (mdavidsaver) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Group 10/4:
Suggest epicsCalcTest() should compare the string expression against the known expected result (for inf/nan calculations) so don't use Freddie's change as currently written to this file.
The epicsMathTest() changes are tricking the optimizer, which is a brittle thing. Idea is to concentrate these kinds of tests in this file, to document the known issues. As a result removing the compiler checks and calls to testToDo() from here is less helpful, we'd still like to see those until we stop building on compilers that fail. Having ToDo tests pass isn't a problem.
AI on MAD to merge and fix this.