Merge lp://staging/~frankban/juju-quickstart/optional-fields into lp://staging/juju-quickstart
Proposed by
Francesco Banconi
Status: | Merged |
---|---|
Merged at revision: | 129 |
Proposed branch: | lp://staging/~frankban/juju-quickstart/optional-fields |
Merge into: | lp://staging/juju-quickstart |
Diff against target: |
293 lines (+73/-35) 4 files modified
quickstart/cli/forms.py (+2/-1) quickstart/models/envs.py (+56/-19) quickstart/tests/models/test_envs.py (+11/-11) tox.ini (+4/-4) |
To merge this branch: | bzr merge lp://staging/~frankban/juju-quickstart/optional-fields |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+257913@code.staging.launchpad.net |
Description of the change
Update provider fields.
Update the list of fields that quickstart
expects for each provider type. Also make
some OpenStack fields optional
(use-floating-ip, tenant-name and region).
Update the links to the provider documentation
(use jujucharms.com).
Update the jujubundlelib dependency to use the
latest one.
Tests: `make check`.
QA:
- check that the environment editing in the
interactive session looks good
(especially the openstack/azure environments
creation).
- use quickstart as usual
(`devenv/
(for instance) an ec2 or an azure environment.
To post a comment you must log in.
Reviewers: mp+257913_ code.launchpad. net,
Message:
Please take a look.
Description:
Update provider fields.
Update the list of fields that quickstart
expects for each provider type. Also make
some OpenStack fields optional
(use-floating-ip, tenant-name and region).
Update the links to the provider documentation
(use jujucharms.com).
Update the jujubundlelib dependency to use the
latest one.
Tests: `make check`.
QA: bin/juju- quickstart` ), to start
- check that the environment editing in the
interactive session looks good
(especially the openstack/azure environments
creation).
- use quickstart as usual
(`devenv/
(for instance) an ec2 or an azure environment.
https:/ /code.launchpad .net/~frankban/ juju-quickstart /optional- fields/ +merge/ 257913
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/234150043/
Affected files (+75, -35 lines): cli/forms. py models/ envs.py tests/models/ test_envs. py
A [revision details]
M quickstart/
M quickstart/
M quickstart/
M tox.ini