juju-quickstart

Merge lp://staging/~frankban/juju-quickstart/minor-fixes-0 into lp://staging/juju-quickstart

minor-fixes-0
Merge into trunk

Proposed by Francesco Banconi on 2014-01-30

Status:	Merged
Merged at revision:	51
Proposed branch:	lp://staging/~frankban/juju-quickstart/minor-fixes-0
Merge into:	lp://staging/juju-quickstart
Diff against target:	170 lines (+56/-48) 5 files modified HACKING.rst (+8/-0) quickstart/app.py (+22/-22) quickstart/manage.py (+5/-5) quickstart/tests/test_app.py (+20/-20) quickstart/tests/test_manage.py (+1/-1)
To merge this branch:	bzr merge lp://staging/~frankban/juju-quickstart/minor-fixes-0
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Juju GUI Hackers		2014-01-30	Pending
Review via email: mp+203942@code.staging.launchpad.net

Description of the change

Minor fixes to code comments and documentation

Also fixed a possible encoding problem in error handling.

The get_admin_secret function and its test case are just moved, no
need to re-review.

Tests: `make check`.
No QA.

https://codereview.appspot.com/58680043/

Revision history for this message

Francesco Banconi (frankban) wrote on 2014-01-30:

Reviewers: mp+203942_code.launchpad.net,

Message:
Please take a look.

Description:
Minor fixes to code comments and documentation

Also fixed a possible encoding problem in error handling.

The get_admin_secret function and its test case are just moved, no
need to re-review.

Tests: `make check`.
No QA.

https://code.launchpad.net/~frankban/juju-quickstart/minor-fixes-0/+merge/203942

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/58680043/

Affected files (+58, -48 lines):
   M HACKING.rst
   A [revision details]
   M quickstart/app.py
   M quickstart/manage.py
   M quickstart/tests/test_app.py
   M quickstart/tests/test_manage.py