Merge lp://staging/~frankban/juju-quickstart/jujuutils into lp://staging/juju-quickstart

Proposed by Francesco Banconi
Status: Merged
Merged at revision: 120
Proposed branch: lp://staging/~frankban/juju-quickstart/jujuutils
Merge into: lp://staging/juju-quickstart
Diff against target: 1480 lines (+713/-599)
8 files modified
quickstart/app.py (+6/-4)
quickstart/jujutools.py (+127/-0)
quickstart/manage.py (+3/-2)
quickstart/models/bundles.py (+118/-0)
quickstart/tests/models/test_bundles.py (+254/-0)
quickstart/tests/test_jujutools.py (+204/-0)
quickstart/tests/test_utils.py (+0/-397)
quickstart/utils.py (+1/-196)
To merge this branch: bzr merge lp://staging/~frankban/juju-quickstart/jujuutils
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+249073@code.staging.launchpad.net

Description of the change

Refactor/split utils code.

Move code from utils to the new jujutools and models/bundles modules.
This branch only include moved code and it's done
in preparation for the Juju API new login work.

https://codereview.appspot.com/204770043/

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+249073_code.launchpad.net,

Message:
Please take a look.

Description:
Refactor/split utils code.

Move code from utils to the new jujutools and models/bundles modules.
This branch only include moved code and it's done
in preparation for the Juju API new login work.

https://code.launchpad.net/~frankban/juju-quickstart/jujuutils/+merge/249073

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/204770043/

Affected files (+715, -599 lines):
   A [revision details]
   M quickstart/app.py
   A quickstart/jujutools.py
   M quickstart/manage.py
   A quickstart/models/bundles.py
   A quickstart/tests/models/test_bundles.py
   A quickstart/tests/test_jujutools.py
   M quickstart/tests/test_utils.py
   M quickstart/utils.py

Revision history for this message
Brad Crittenden (bac) wrote :

LGTM. Will do QA shortly.

https://codereview.appspot.com/204770043/diff/1/quickstart/models/bundles.py
File quickstart/models/bundles.py (right):

https://codereview.appspot.com/204770043/diff/1/quickstart/models/bundles.py#newcode59
quickstart/models/bundles.py:59: def parse_bundle(bundle_yaml,
bundle_name=None):
Nice that you've made bundles a real person!

https://codereview.appspot.com/204770043/

Revision history for this message
Brad Crittenden (bac) wrote :
Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Refactor/split utils code.

Move code from utils to the new jujutools and models/bundles modules.
This branch only include moved code and it's done
in preparation for the Juju API new login work.

R=bac
CC=
https://codereview.appspot.com/204770043

https://codereview.appspot.com/204770043/

Revision history for this message
Francesco Banconi (frankban) wrote :

Thanks for the review and QA Brad!

https://codereview.appspot.com/204770043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches