lp://staging/~frankban/charms/precise/juju-gui/revision-support

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/~juju-gui/charms/precise/juju-gui/trunk at revision 58

charmers: Pending requested 2013-05-17

Diff: 117 lines (+38/-8)

4 files modified

config.yaml (+2/-1)
hooks/utils.py (+26/-5)
revision (+1/-1)
tests/test_utils.py (+9/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

61. By Francesco Banconi on 2013-05-17

Improve log messages

60. By Francesco Banconi on 2013-05-16

Increased revision.

59. By Francesco Banconi on 2013-05-16

Verbose regexp.

58. By Francesco Banconi on 2013-05-11

Support branch revisions.

57. By Nicola Larosa on 2013-05-03

More charm code cleanup.

Most of these changes were split from the former branch that added
backend unit tests, it was getting too big and unreadable.

No behavior changes, only formatting and two occasions of different
expressions of the same meaning.

R=frankban, gary.poster
CC=
https://codereview.appspot.com/9125046

56. By Francesco Banconi on 2013-05-03

Fix import errors in stop hook.

This branch includes three trivial fixes:
- stop hook not working;
- using https://manage.jujucharms.com as charmworld URL by default;
- no need to provide credentials in sandbox mode.

R=teknico, gary.poster
CC=
https://codereview.appspot.com/9125043

55. By Nicola Larosa on 2013-05-02

Add more unit tests to the charm backend.

More unit tests for backend properties, commands and methods.
In order to do that, it mangles the charm code pretty heavily:

- it adds module prefixes to all functions imported by backend.py in order to
  make them monkeypatchable in tests;
- it renames all sub-backends to mixins, for clarity. Arguably, "backend.mixins
  lists all active mixins" is clearer than "backend.backends lists all active
  sub-backends, some of which are actual backends and some others are mixins";
- it simplifies the code in a number of places;
- it removes unused or scarcely used code in backend.py, for simplicity;
- it rephrases some docstrings in more specific terms, for readability;
- it removes the overrideable testing framework in backend.py. It imposes a
  runtime and complexity cost for doing what is already done in other tests by
  monkeypatching;

Further style changes have been moved to a subsequent branch.

It also fixes two import errors.

WARNING: this branch did successfully deploy a stable juju-gui release.
Deploy tests did not run successfully though, and they seem to be broken
in trunk too, right now.

R=bcsaller, frankban
CC=
https://codereview.appspot.com/9121043

54. By Nicola Larosa on 2013-05-02

Reinstate test symbolic links.

Actually reinstate test symbolic links that were mistakenly
replaced with copies of the linked files.

Trivial, self-reviewed.

R=
CC=
https://codereview.appspot.com/9106044

53. By Benji York on 2013-04-30

add missing parameter

52. By Benji York on 2013-04-30

fix accedentally removed symlinks