Merge lp://staging/~frankban/charms/precise/juju-gui/guiserver-auth-fixes into lp://staging/~juju-gui/charms/precise/juju-gui/trunk
Proposed by
Francesco Banconi
Status: | Merged |
---|---|
Merged at revision: | 86 |
Proposed branch: | lp://staging/~frankban/charms/precise/juju-gui/guiserver-auth-fixes |
Merge into: | lp://staging/~juju-gui/charms/precise/juju-gui/trunk |
Diff against target: |
409 lines (+82/-50) 7 files modified
server/guiserver/apps.py (+8/-5) server/guiserver/auth.py (+11/-5) server/guiserver/handlers.py (+7/-3) server/guiserver/tests/test_apps.py (+0/-7) server/guiserver/tests/test_auth.py (+17/-2) server/guiserver/tests/test_handlers.py (+37/-27) server/guiserver/tests/test_manage.py (+2/-1) |
To merge this branch: | bzr merge lp://staging/~frankban/charms/precise/juju-gui/guiserver-auth-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
charmers | Pending | ||
Review via email: mp+179014@code.staging.launchpad.net |
Description of the change
Authentication fixes.
Fixed an error in the guiserver authentication
when the request id is set to 0.
Moved the auth_backend from the app to the
handler: it is only relevant in the WebSocketHandler
context.
Some clean up in the tests.
To post a comment you must log in.
Reviewers: mp+179014_ code.launchpad. net,
Message:
Please take a look.
Description:
Authentication fixes.
Fixed an error in the guiserver authentication
when the request id is set to 0.
Moved the auth_backend from the app to the
handler: it is only relevant in the WebSocketHandler
context.
Some clean up in the tests.
https:/ /code.launchpad .net/~frankban/ charms/ precise/ juju-gui/ guiserver- auth-fixes/ +merge/ 179014
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/12612043/
Affected files: guiserver/ apps.py guiserver/ auth.py guiserver/ handlers. py guiserver/ tests/test_ apps.py guiserver/ tests/test_ auth.py guiserver/ tests/test_ handlers. py guiserver/ tests/test_ manage. py
A [revision details]
M server/
M server/
M server/
M server/
M server/
M server/
M server/