Merge lp://staging/~frankban/charms/precise/juju-gui/guiserver-auth-fixes into lp://staging/~juju-gui/charms/precise/juju-gui/trunk

Proposed by Francesco Banconi
Status: Merged
Merged at revision: 86
Proposed branch: lp://staging/~frankban/charms/precise/juju-gui/guiserver-auth-fixes
Merge into: lp://staging/~juju-gui/charms/precise/juju-gui/trunk
Diff against target: 409 lines (+82/-50)
7 files modified
server/guiserver/apps.py (+8/-5)
server/guiserver/auth.py (+11/-5)
server/guiserver/handlers.py (+7/-3)
server/guiserver/tests/test_apps.py (+0/-7)
server/guiserver/tests/test_auth.py (+17/-2)
server/guiserver/tests/test_handlers.py (+37/-27)
server/guiserver/tests/test_manage.py (+2/-1)
To merge this branch: bzr merge lp://staging/~frankban/charms/precise/juju-gui/guiserver-auth-fixes
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+179014@code.staging.launchpad.net

Description of the change

Authentication fixes.

Fixed an error in the guiserver authentication
when the request id is set to 0.

Moved the auth_backend from the app to the
handler: it is only relevant in the WebSocketHandler
context.

Some clean up in the tests.

https://codereview.appspot.com/12612043/

To post a comment you must log in.
Revision history for this message
Francesco Banconi (frankban) wrote :

Reviewers: mp+179014_code.launchpad.net,

Message:
Please take a look.

Description:
Authentication fixes.

Fixed an error in the guiserver authentication
when the request id is set to 0.

Moved the auth_backend from the app to the
handler: it is only relevant in the WebSocketHandler
context.

Some clean up in the tests.

https://code.launchpad.net/~frankban/charms/precise/juju-gui/guiserver-auth-fixes/+merge/179014

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/12612043/

Affected files:
   A [revision details]
   M server/guiserver/apps.py
   M server/guiserver/auth.py
   M server/guiserver/handlers.py
   M server/guiserver/tests/test_apps.py
   M server/guiserver/tests/test_auth.py
   M server/guiserver/tests/test_handlers.py
   M server/guiserver/tests/test_manage.py

Revision history for this message
Benjamin Saller (bcsaller) wrote :

LGTM

The whole 'is not None' things gets us all from time to time.

Thanks

https://codereview.appspot.com/12612043/

Revision history for this message
Madison Scott-Clary (makyo) wrote :

Did not QA, but LGTM, thanks!

https://codereview.appspot.com/12612043/

Revision history for this message
Francesco Banconi (frankban) wrote :

*** Submitted:

Authentication fixes.

Fixed an error in the guiserver authentication
when the request id is set to 0.

Moved the auth_backend from the app to the
handler: it is only relevant in the WebSocketHandler
context.

Some clean up in the tests.

R=benjamin.saller, matthew.scott
CC=
https://codereview.appspot.com/12612043

https://codereview.appspot.com/12612043/

Revision history for this message
Francesco Banconi (frankban) wrote :

Thank you both for the reviews!

https://codereview.appspot.com/12612043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches