lp://staging/~frankban/charms/precise/juju-gui/bug-1100194-add-charm-options

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/~juju-gui/charms/precise/juju-gui/trunk at revision 26

Juju GUI Hackers: Pending requested 2013-01-16

Diff: 249 lines (+103/-17)

7 files modified

config.yaml (+22/-0)
config/config.js.template (+3/-0)
hooks/config-changed (+9/-5)
hooks/start (+3/-2)
hooks/utils.py (+24/-6)
revision (+1/-1)
tests/test_utils.py (+41/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1100194: Add username, password and read-only options to the charm

Medium

Fix Released

Link a bug report

Related blueprints

34. By Francesco Banconi on 2013-01-17

Changes per review.

33. By Francesco Banconi on 2013-01-16

Handle user and password options when staging is true.

32. By Francesco Banconi on 2013-01-16

Fixed unit tests.

31. By Francesco Banconi on 2013-01-16

Updated config-changed hook.

30. By Francesco Banconi on 2013-01-16

Implemented user, password, and read-only on charm start.

29. By Francesco Banconi on 2013-01-16

Updated the GUI configuration template.

28. By Francesco Banconi on 2013-01-16

Updated user option.

27. By Francesco Banconi on 2013-01-16

Add new options in config.yaml.

26. By Francesco Banconi on 2013-01-16

Bumped revision up.

25. By Francesco Banconi on 2013-01-11

Juju GUI source as env var + Charm test branch

This branch introduces the possibility to provide
the Juju GUI source (used in tests) by setting an
environment variable. This way the charm tests can
be run as part of the release qa process, e.g.:

$ JUJU_GUI_SOURCE=lp:mybranch jitsu test juju-gui ...

or, to test a new trunk release:

$ JUJU_GUI_SOURCE=trunk jitsu test juju-gui ...

Also updated the test exercising the process of
making a release from a branch, i.e. when the
juju-gui-source option points to a Bazaar branch.

Now the branch used is a customized one, present in
`lp:~frankban/juju-gui/charm-tests-branch` (please
feel free to suggest another, more sane, location,
and please take a look at that as part of your reviews).
This is a test branch containing only a minimal
Makefile and a release tarball. There, `make distfile`
is almost a no-op, and for this reason the charm test
speed is slightly increased (~4 minutes on ec2).
Source: http://bazaar.launchpad.net/~frankban/juju-gui/charm-tests-branch/files

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7102044