Merge lp://staging/~frankban/charms/oneiric/buildbot-slave/initial into lp://staging/~yellow/charms/oneiric/buildbot-slave/trunk

Proposed by Francesco Banconi
Status: Approved
Approved by: Gary Poster
Approved revision: 10
Proposed branch: lp://staging/~frankban/charms/oneiric/buildbot-slave/initial
Merge into: lp://staging/~yellow/charms/oneiric/buildbot-slave/trunk
Diff against target: 121 lines (+81/-0)
8 files modified
config.yaml (+17/-0)
hooks/buildbot-relation-changed (+18/-0)
hooks/config-changed (+2/-0)
hooks/install (+10/-0)
hooks/start (+5/-0)
hooks/stop (+7/-0)
metadata.yaml (+21/-0)
revision (+1/-0)
To merge this branch: bzr merge lp://staging/~frankban/charms/oneiric/buildbot-slave/initial
Reviewer Review Type Date Requested Status
Gary Poster (community) Approve
Review via email: mp+90739@code.staging.launchpad.net

Description of the change

Fisr working implementation of the buildbot slave charm.

To post a comment you must log in.
8. By Francesco Banconi

Cleaned old stuff coming from the master charm.

9. By Francesco Banconi

Cleaned config-changed file.

10. By Francesco Banconi

Cleaned install hook.

Revision history for this message
Gary Poster (gary) wrote :

Thank you for cleaning out the unnecessary master changes as we discussed on a hangout.

hooks/buildbot-relation-changed will be idempotent after we move the installation to the install step, so I won't worry about that.

review: Approve

Unmerged revisions

10. By Francesco Banconi

Cleaned install hook.

9. By Francesco Banconi

Cleaned config-changed file.

8. By Francesco Banconi

Cleaned old stuff coming from the master charm.

7. By Francesco Banconi

First working implementation of buildbot slave.

6. By Graham Binns

Basic tweaks from Master config.

5. By Brad Crittenden

make user and pkey optional when pulling from a public url

4. By Brad Crittenden

Incomplete work towards config directory checkout

3. By Brad Crittenden

Works against LXC

2. By Brad Crittenden

Fix expose

1. By Brad Crittenden

Almost working buildbot master charm

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches