Merge lp://staging/~frankban/charms/oneiric/buildbot-master/trunk into lp://staging/~yellow/charms/oneiric/buildbot-master/trunk

Proposed by Francesco Banconi
Status: Merged
Approved by: Gary Poster
Approved revision: 8
Merged at revision: 8
Proposed branch: lp://staging/~frankban/charms/oneiric/buildbot-master/trunk
Merge into: lp://staging/~yellow/charms/oneiric/buildbot-master/trunk
Diff against target: 39 lines (+5/-11)
3 files modified
hooks/stop (+1/-1)
metadata.yaml (+3/-9)
revision (+1/-1)
To merge this branch: bzr merge lp://staging/~frankban/charms/oneiric/buildbot-master/trunk
Reviewer Review Type Date Requested Status
Gary Poster (community) Approve
Review via email: mp+90732@code.staging.launchpad.net

Description of the change

The buildbot master charm now provides a buildbot relationship with *master* interface.

To post a comment you must log in.
8. By Francesco Banconi

Merged parent branch and resolved conflicts.

Revision history for this message
Gary Poster (gary) wrote :

Looks good, thank you. I agree that the master should provide an interface, and the slave should require that interface.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches