Merge lp://staging/~francesco-marella/specto/code-to-glade into lp://staging/specto
Proposed by
Francesco Marella
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~francesco-marella/specto/code-to-glade |
Merge into: | lp://staging/specto |
Diff against target: |
1731 lines (+626/-427) 7 files modified
data/uis/about.ui (+59/-0) data/uis/import_export.ui (+117/-24) data/uis/notifier.ui (+399/-186) spectlib/about.py (+8/-25) spectlib/export_watch.py (+15/-59) spectlib/import_watch.py (+15/-54) spectlib/notifier.py (+13/-79) |
To merge this branch: | bzr merge lp://staging/~francesco-marella/specto/code-to-glade |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeff Fortin Tam | Needs Fixing | ||
Review via email:
|
To post a comment you must log in.
Unmerged revisions
- 169. By Francesco Marella
-
vertical scrollbar -> never
- 168. By Francesco Marella
-
some fixes, but the checkboxes are still not centered
thanks to Jeff for pointing out these regressions.
- 167. By Francesco Marella
-
Move GUI code to Glade files (treeview related code mostly)
Glade (v. 3.8) it's a great tool for GUI creation and improved so much (read as no frequent crashes).
The process of migrate Specto to PyGI and GTK+ 3.0 will be easier and painless (hopefully).GTK+ >= 2.18 is required.
This is quite interesting! A couple of things though:
- mousing over the "Add" submenu makes two menus appear (the toolbar's popup menu shows up). Wtf?
- how do we actually edit the contents now? What's the difference in the glade editor?
- maybe you want to take a look at lp:~kiddo/specto/pygi too
- I guess this simplifies the code a lot, however I'd like someone else to review this too
- it looks different than the current UI... the patch below makes it ressemble the main branch more, but it still has different column headers, the checkboxes are not centered, etc.
=== modified file 'data/uis/ notifier. ui' notifier. ui 2011-05-13 09:56:54 +0000 notifier. ui 2011-05-15 22:15:31 +0000 naming- policy toplevel-contextual --> GtkAccelGroup" id="accelgroup1"/> focus"> False</ property>
<object class=" GtkScrolledWind ow" id="scrolledwin dow1">
<property name="visible" >True</ property>
<property name="can_ focus"> True</property> r_policy" >automatic< /property> r_policy" >automatic< /property>
<child>
<object class="GtkTextView" id="error_message">
<property name="height_ request" >200</property>
< property name="visible" >True</ property>
< property name="can_ focus"> True</property>
< property name="hscrollba r_policy" >never< /property> r_policy" >automatic< /property>
< property name="shadow_ type">in< /property>
< child>
<object class="GtkTreeView" id="treeview">
<property name="visible" >True</ property>
<property name="can_ focus"> True</property>
<property name="model" >liststore< /property> clickable" >False< /property> hint">True< /property>
<property name="search_ column" >0</property> grid_lines" >both</ property>
<signal name="cursor- changed" handler= "show_watch_ info" swapped="no"/>
<signal name="row- activated" handler= "open_watch_ callback" swapped="no"/> child=" selection" > GtkTreeSelectio n" id="treeview- selection1" />
<child>
<object class=" GtkTreeViewColu mn" id="select_ treeviewcolumn" >
<property name="title" translatable= "yes">Select< /property>
--- data/uis/
+++ data/uis/
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<interface>
<requires lib="gtk+" version="2.18"/>
- <!-- interface-
<object class="
<object class="GtkWindow" id="error_dialog">
<property name="can_
@@ -57,8 +56,6 @@
- <property name="hscrollba
- <property name="vscrollba
@@ -612,18 +609,19 @@
- <property name="vscrollba
- <property name="headers_
+ <property name="rules_
- <property name="enable_
+ <child internal-
+ <object class="
+ </child>