ubiquity

Merge lp://staging/~fossfreedom/ubiquity/use_gsd_for_budgie into lp://staging/ubiquity

  1. use_gsd_for_budgie
  2. Merge into trunk
Proposed by fossfreedom
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 6523
Merged at revision: 6522
Proposed branch: lp://staging/~fossfreedom/ubiquity/use_gsd_for_budgie
Merge into: lp://staging/ubiquity
Diff against target: 15 lines (+0/-5)
1 file modified
bin/ubiquity-dm (+0/-5)
To merge this branch: bzr merge lp://staging/~fossfreedom/ubiquity/use_gsd_for_budgie
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
fossfreedom (community) Needs Resubmitting
Adam Conrad (community) Disapprove
Review via email: mp+316787@code.staging.launchpad.net

Description of the change

as per bug-report https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1663058 description

To post a comment you must log in.
Revision history for this message
Adam Conrad (adconrad) wrote :

If you have both usd and gsd installed, that's a bug, not a feature. Ubiquity shouldn't be working around it.

review: Disapprove
Revision history for this message
Jeremy Bícha (jbicha) wrote :

According to the manifest, Ubuntu Budgie shouldn't have unity-settings-daemon installed:

http://cdimage.ubuntu.com/ubuntu-budgie/daily-live/current/zesty-desktop-amd64.manifest

lp://staging/~fossfreedom/ubiquity/use_gsd_for_budgie updated
6523. By fossfreedom

remove the unnecessary forced install of gsd

Revision history for this message
fossfreedom (fossfreedom) wrote :

> If you have both usd and gsd installed, that's a bug, not a feature. Ubiquity
> shouldn't be working around it.

@adconrad - you know working on alpha-beta's are fun!

Nothing what Ubuntu Budgie has done I swear - unity-settings-daemon has now disappeared from our ISO.

That's excellent!

I've removed the offending code and hopefully the if statement should now fall through and load gsd.

review: Needs Resubmitting
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks good like this; now that we've verified the state of a settings daemon in the image.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: