Merge lp://staging/~fo0bar/turku/turku-storage-log-output into lp://staging/turku
Proposed by
Ryan Finnie
| Status: | Merged |
|---|---|
| Approved by: | Barry Price |
| Approved revision: | 40 |
| Merged at revision: | 39 |
| Proposed branch: | lp://staging/~fo0bar/turku/turku-storage-log-output |
| Merge into: | lp://staging/turku |
| Diff against target: |
46 lines (+14/-21) 1 file modified
turku_storage/ping.py (+14/-21) |
| To merge this branch: | bzr merge lp://staging/~fo0bar/turku/turku-storage-log-output |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stuart Bishop (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2020-06-20.
Commit message
Log run output directly to logger
Description of the change
Python 2.7 made real-time logging of subprocess piped output difficult
(and actually a bit dangerous). But now that Turku is Python 3, Popen's
context manager will DTRT and clean up after itself, so we don't need an
intermediary.
Note that this removes return_output from run_logging(), but
return_output was not actually used.
To post a comment you must log in.
Revision history for this message
| 🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote | # |
Revision history for this message
| 🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote | # |
Revision history for this message
| 🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This merge proposal is being monitored by mergebot. Change the status to Approved to merge.