Merge lp://staging/~fo0bar/turku/turku-api-focal into lp://staging/turku/turku-api

Proposed by Ryan Finnie
Status: Merged
Approved by: Joel Sing
Approved revision: 63
Merged at revision: 63
Proposed branch: lp://staging/~fo0bar/turku/turku-api-focal
Merge into: lp://staging/turku/turku-api
Diff against target: 115 lines (+17/-10)
4 files modified
turku_api/admin.py (+4/-1)
turku_api/models.py (+6/-6)
turku_api/settings.py (+2/-1)
turku_api/urls.py (+5/-2)
To merge this branch: bzr merge lp://staging/~fo0bar/turku/turku-api-focal
Reviewer Review Type Date Requested Status
Joel Sing (community) +1 Approve
Review via email: mp+382102@code.staging.launchpad.net

Commit message

Add compatibility for Django 2.2 (Ubuntu focal)

Description of the change

- reverse/reverse_lazy changed from django.core.urlresolvers to
  django.urls
- MIDDLEWARE_CLASSES changed to MIDDLEWARE
- Model ForeignKey on_delete=models.CASCADE changed from implicit to
  explicit

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Joel Sing (jsing) wrote :

LGTM, thanks.

review: Approve (+1)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 63

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: