Turku Backup System

Merge lp://staging/~fo0bar/turku/turku-agent-cleanup into lp://staging/turku/turku-agent

  1. turku-agent-cleanup
  2. Merge into turku-agent
Proposed by Ryan Finnie
Status: Merged
Approved by: Barry Price
Approved revision: 57
Merged at revision: 57
Proposed branch: lp://staging/~fo0bar/turku/turku-agent-cleanup
Merge into: lp://staging/turku/turku-agent
Diff against target: 1204 lines (+487/-298)
10 files modified
.bzrignore (+61/-5)
MANIFEST.in (+13/-0)
Makefile (+28/-0)
setup.py (+13/-13)
tests/test_stub.py (+8/-0)
tox.ini (+38/-0)
turku_agent/ping.py (+108/-84)
turku_agent/rsyncd_wrapper.py (+11/-7)
turku_agent/update_config.py (+71/-69)
turku_agent/utils.py (+136/-120)
To merge this branch: bzr merge lp://staging/~fo0bar/turku/turku-agent-cleanup
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Review via email: mp+386145@code.staging.launchpad.net

Commit message

Mega-noop cleanup

Description of the change

This is the minimum required for:
- tox test suite with all passing tests
- black-managed formatting
- Shippable sdist module

It is intended as a base for the other MPs, so they don't have to e.g. establish tests/*, or worry about about existing failing flake8, or worry about how to add additional optional modules.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

lp://staging/~fo0bar/turku/turku-agent-cleanup updated
57. By Ryan Finnie

Mega-noop cleanup

- Sort imports
- Remove shabangs from non-scripts
- Update MANIFEST.in so `setup.py sdist` produces usable tarballs
- Create stub tests
- Add tox.ini
- Add blank requirements.txt
- Add Makefile
- make black
- Update .bzrignore
- Clean up flake8:
  - update_config.py: '.utils.json_dump_p' imported but unused
  - update_config.py: 'api_reply' is assigned to but never used
  - utils.py: 'sources_secrets_d' is assigned to but never used

Revision history for this message
Stuart Bishop (stub) wrote :

Looks good. The new bits seem fine (bzr, buildchain, tox). The code changes all appear to be nothing but Black reformatting (as expected).

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 57

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: