Merge lp://staging/~fo0bar/juju-wait/juju-wait-quicker into lp://staging/~stub/juju-wait/trunk-migrated-to-git
Proposed by
Ryan Finnie
| Status: | Merged |
|---|---|
| Merged at revision: | 41 |
| Proposed branch: | lp://staging/~fo0bar/juju-wait/juju-wait-quicker |
| Merge into: | lp://staging/~stub/juju-wait/trunk-migrated-to-git |
| Diff against target: |
79 lines (+33/-15) 1 file modified
juju_wait/__init__.py (+33/-15) |
| To merge this branch: | bzr merge lp://staging/~fo0bar/juju-wait/juju-wait-quicker |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stuart Bishop | Approve | ||
|
Review via email:
|
|||
Description of the change
Ignore update-status hook, check leaders after IDLE_CONFIRMATION loop
These two changes are intended to reduce wait time on large
environments.
~Recent juju (1.24+?) regularly runs housekeeping hooks, the most common
of which is update-status. On a large environment, there is almost
always an update-status run in the last 15 seconds, but juju-wait should
not block on this.
Run the leaders block after the IDLE_CONFIRMATION block, as checking
leadership on an environment with many services takes a significant
amount of time, and is the least likely to set ready = False and begin
the whole process again. Running this last will make it so it's
(usually) only ever run once, at the very end.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Yup.