Ubuntu
openvswitch package

Merge ~fnordahl/ubuntu/+source/openvswitch:bug/1915829 into ~ubuntu-server-dev/ubuntu/+source/openvswitch:master

  1. Git
  2. lp:~fnordahl/ubuntu/+source/openvswitch
  3. bug/1915829
  4. Merge into master
Proposed by Frode Nordahl
Status: Merged
Merge reported by: Frode Nordahl
Merged at revision: e74d2a0273e1d73fd274208842ea5a81c5654aaa
Proposed branch: ~fnordahl/ubuntu/+source/openvswitch:bug/1915829
Merge into: ~ubuntu-server-dev/ubuntu/+source/openvswitch:master
Diff against target: 251 lines (+174/-2)
8 files modified
debian/changelog (+18/-0)
debian/openvswitch-switch.ovs-record-hostname.service (+18/-0)
debian/openvswitch-switch.ovs-vswitchd.service (+2/-0)
debian/openvswitch-switch.ovsdb-server.service (+3/-1)
debian/openvswitch-switch.service (+1/-0)
debian/patches/ovs-dev-ovs-ctl-Allow-recording-hostname-separately.patch (+129/-0)
debian/patches/series (+1/-0)
debian/rules (+2/-1)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  Needs Fixing
Review via email: mp+398174@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hirsute isn't released yet - so it would be 2.15.0-0ubuntu2

Other than this minor issue it does LGTM.
Of course to avoid diverging too much you might want to wait to see it accepted upstream before uploading (depends on how close that accept gets to the Freeze).

Also FYI - 2.15.0 still is held in -unapproved as we are soft freezing atm
https://launchpad.net/ubuntu/hirsute/+queue?queue_state=1
(Just in case you wondered)

review: Needs Fixing
Revision history for this message
Frode Nordahl (fnordahl) wrote :

Thank you for the review Christian.

Updated the package version and updated the patch to now match the version merged upstream [0].

We got it backported all the way to 2.13, but I would like to proceed with carrying it as a patch in the packaging until a upstream point release is cut as there are downstream issues waiting to be resolved by this fix.

Hope this resonates well with you.

0: https://mail.openvswitch.org/pipermail/ovs-dev/2021-March/380889.html

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches