Merge lp://staging/~fluidity-core/fluidity/speedup-vtudiff into lp://staging/fluidity
Status: | Merged |
---|---|
Merged at revision: | 4320 |
Proposed branch: | lp://staging/~fluidity-core/fluidity/speedup-vtudiff |
Merge into: | lp://staging/fluidity |
Diff against target: |
386 lines (+101/-212) 2 files modified
manual/visualisation_and_diagnostics.tex (+1/-13) python/vtktools.py (+100/-199) |
To merge this branch: | bzr merge lp://staging/~fluidity-core/fluidity/speedup-vtudiff |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jon Hill | Approve | ||
Review via email: mp+201957@code.staging.launchpad.net |
Description of the change
This speeds up the vtudiff script run on vtus with multiple fields, by only setting up the VTK probe once instead of once per field. It does not change anything in the way fields are probed.
There is also a little bit of cleaning up:
* removing the option to call vtktools as a main: this really doesn't make sense and should be in a separate script
* removing the "field manipulation" methods. These were basically vectorial operations on fields but implemented in a rather inefficient way. I see no reason to not simply use numpy vector operations for that, so instead of:
vtu.SubFieldFro
just do:
field = vtu.GetField(
vtu.AddField(
Thanks Jon, will merge once I have a green buildbot.