Merge lp://staging/~flscogna/ubuntu-terminal-app/profile-selection into lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

PASSED: Continuous integration, rev:73
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/144/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2481
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2481/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/65
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-vivid-amd64-ci/28

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/144/rebuild

I set no profiles active, but still see the keyboard button. Can we hide that when all keyboard layouts are disabled?

http://people.canonical.com/~alan/screenshots/device-2015-04-13-120147.png

Other than that, looks great.

Alan, we can theoretically hide the keyboard button, but what about the row? If we hide only the button, we would basically have a black useless rectangle at the bottom.
Let's discuss some options:

1) Leave the current situation, with a useless bar and a useless button. (quite bad but predictable)
2) Hide the keyboard bar when no profiles are selected. (might be confusing?)
3) Force at least one profiles to be active (e.g. your ubuntu layout).

What do you think?

I prefer 2).

If someone doesn't want to 'waste' the screen real-estate used by the layout, so switches them all off, they'll be disappointed that they don't gain space IMO.

If we force a profile to be active, we're forcing that 'waste' of space for users who don't need it.

I would default to having the layouts enabled by default, but if the user actively has chosen to disable them _all_ then they should expect the consequence that they're gone from the main UI. They've already discovered how to disable them, re-enabling them shouldn't be a stretch for them.

What do you think?

We already have a setting to completely disable the keyboard bar (in the main page).
The state which might be confusing here is: "Show Keyboard Bar" is turned on, but all profiles are disabled.

I'd personally not mix profiles selection with bar visibility. I'm thinking some day we'll have a keyboard shortcut to show/hide the bar, and we need to preserve the state (read the profiles enabled).

I'm inclined to think the best solution is to always show the additional bar (provided "Show Keyboard Bar" is enabled), but grey out the button when no profile is selected.
If the users wants to recover the screen real-estate (temporarily or permanently) it is just a tick away, without the need to change anything about its favourites profiles.

I perfectly agree with the default choices.

Ok, you make a good argument. Let's go with your plan.

Are you planning to add the grey icon in this merge? If so, when can we expect that?

Sorry, I completely forgot about this merge proposal. I'll work on it in
the next two days.

2015-05-19 11:22 GMT+02:00 Alan Pope  <email address hidden>:

> Are you planning to add the grey icon in this merge? If so, when can we
> expect that?
> --
>
> https://code.launchpad.net/~flscogna/ubuntu-terminal-app/profile-selection/+merge/255077
> You are the owner of lp:~flscogna/ubuntu-terminal-app/profile-selection.
>

PASSED: Continuous integration, rev:75
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/146/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2797
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2797/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/67
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-vivid-amd64-ci/30

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/146/rebuild

Alan, when you have some time give this a go. The colour might be tweaked a bit, but I think the result is decent.

There seems to be a breakage in some use cases.

Add a few layouts
Go back to the main terminal screen
Select one as the current one
Go back to layout settings, de-select the one set as current

Expected behaviour:- Switch to another layout (next in list for example), or un-set a layout

Actual behaviour can sometimes be:-

* No layout set, choosing a layout has no effect:-
http://people.canonical.com/~alan/screenshots/device-2015-05-27-155914.png
http://people.canonical.com/~alan/screenshots/device-2015-05-27-155920.png

FAILED: Continuous integration, rev:76
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/148/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2870/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/69/console
    FAILURE: http://91.189.93.70:8080/job/ubuntu-terminal-app-vivid-amd64-ci/32/console

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/148/rebuild

Ok, there was an issue when the last profile was active and unselected from the settings. This should work fine now.

PASSED: Continuous integration, rev:77
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/149/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2871
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/2871/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/70
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-vivid-amd64-ci/33

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/149/rebuild

That fixed it!