Merge lp://staging/~flscogna/ubuntu-terminal-app/fix-add-forceAuth into lp://staging/ubuntu-terminal-app
| Status: | Rejected |
|---|---|
| Rejected by: | Nicholas Skaggs |
| Proposed branch: | lp://staging/~flscogna/ubuntu-terminal-app/fix-add-forceAuth |
| Merge into: | lp://staging/ubuntu-terminal-app |
| Diff against target: |
58 lines (+23/-1) 2 files modified
src/app/main.cpp (+22/-0) src/app/qml/AuthenticationService.qml (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~flscogna/ubuntu-terminal-app/fix-add-forceAuth |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Nicholas Skaggs (community) | Disapprove | ||
| Ubuntu Phone Apps Jenkins Bot | continuous-integration | Approve | |
| Alan Pope 🍺🐧🐱 🦄 | Pending | ||
|
Review via email:
|
|||
Commit message
Add the --forceAuth flag to terminal-app
Description of the change
This should add the --forceAuth flag to launch the application bypassing the authentication.
Sadly tonight the emulator is not working for me so I could only check that the code actually compiles, so please use extra care.
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | # |
| Nicholas Skaggs (nskaggs) wrote | # |
| Filippo Scognamiglio (flscogna) wrote | # |
Unmerged revisions
- 150. By Filippo Scognamiglio
-
Add fake --forceAuth flag (needed for autopilot tests).
- 149. By Launchpad Translations on behalf of ubuntu-terminal-dev
-
Launchpad automatic translations update.
- 148. By Launchpad Translations on behalf of ubuntu-terminal-dev
-
Launchpad automatic translations update.
- 147. By Kill Animals
-
Update lib version imports.
Approved by Alan Pope ʕ•͡ᴥ•ʔ, Ubuntu Phone Apps Jenkins Bot.
- 146. By Victor Thompson
-
Clear password field when OK is pressed. Fixes: https:/
/bugs.launchpad .net/bugs/ 1366387. Approved by Alan Pope ʕ•͡ᴥ•ʔ, Ubuntu Phone Apps Jenkins Bot.
- 145. By Benjamin Zeller
-
Make terminal app cmake project useable out of the Box with QtCreator
(after dependencies are installed)
- Enable click mode by default
- Disable click mode in debian rules file
- Add variable UBUNTU_MANIFEST_ PATH variable so QtC knows where to look
for the manifest file
- Rename apparmor.json to terminal.apparmor (editor support)
- Rename manifest.json => manifest.json.in so insource builds won't
override it.Approved by Alan Pope ʕ•͡ᴥ•ʔ, Ubuntu Phone Apps Jenkins Bot.
- 144. By Filippo Scognamiglio
-
Fix: terminal starts in application directory instead of home. Fixes: https:/
/bugs.launchpad .net/bugs/ 1365602. Approved by Alan Pope ʕ•͡ᴥ•ʔ, Ubuntu Phone Apps Jenkins Bot.
- 143. By Launchpad Translations on behalf of ubuntu-terminal-dev
-
Launchpad automatic translations update.
- 142. By Launchpad Translations on behalf of ubuntu-terminal-dev
-
Launchpad automatic translations update.
- 141. By Michael Sheldon
-
Set input hint to disable predictive text and auto capitalisation in custom terminal input implementation. Fixes: https:/
/bugs.launchpad .net/bugs/ 1302870, https:/ /bugs.launchpad .net/bugs/ 1307386, https:/ /bugs.launchpad .net/bugs/ 1331354. Approved by Ubuntu Phone Apps Jenkins Bot, Alan Pope ㋛, Filippo Scognamiglio.
PASSED: Continuous integration, rev:150
http://
Executed test runs:
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://