Ubuntu Terminal App

Merge lp://staging/~flscogna/ubuntu-terminal-app/fix-1363902 into lp://staging/ubuntu-terminal-app

  1. fix-1363902
  2. Merge into trunk
Proposed by Filippo Scognamiglio
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 🦄
Approved revision: 131
Merged at revision: 135
Proposed branch: lp://staging/~flscogna/ubuntu-terminal-app/fix-1363902
Merge into: lp://staging/ubuntu-terminal-app
Diff against target: 38 lines (+8/-4)
1 file modified
src/app/qml/Configs.qml (+8/-4)
To merge this branch: bzr merge lp://staging/~flscogna/ubuntu-terminal-app/fix-1363902
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 🦄 (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+232907@code.staging.launchpad.net

Commit message

Correct behavior of effects switch. Fixes 1363902 .

Description of the change

Unbreak effect switch behavior, fixes bug 1363902

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:131
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~flscogna/ubuntu-terminal-app/fix-1363902/+merge/232907/+edit-commit-message

http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/90/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1763/console
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1763/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/34

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/90/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:131
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/93/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1835
        deb: http://91.189.93.70:8080/job/generic-mediumtests-utopic/1835/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-terminal-app-utopic-amd64-ci/37

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-terminal-app-ci/93/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Thanks for this, tested on device.

Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches