Merge lp://staging/~florian-angermeier/contractor/filter-functions-based-on-file-size into lp://staging/contractor/0.3

Nice work, thanks :)

See below a few comments about code style and some other things.

We also need documentations for the public methods to get this merged, which will be used to generate the api docs (see other files (e.g. the widgets are well documented) if you are looking for examples).

> Nice work, thanks :)
>
> See below a few comments about code style and some other things.
>
> We also need documentations for the public methods to get this merged, which
> will be used to generate the api docs (see other files (e.g. the widgets are
> well documented) if you are looking for examples).

=== modified file 'src/Contract.vala'
 --- src/Contract.vala 2013-05-20 04:55:11 +0000
 +++ src/Contract.vala 2015-09-13 00:54:10 +0000
 @@ -72,6 +77,12 @@
              } catch (Error err) {
                  warning ("Contract '%s' does not provide an icon (%s)", id, err.message);
              }
 +
 + try {
 + max_file_size = keyfile.get_max_file_size ();
 + } catch (Error err) {
 + warning ("Contract '%s' does not provide a max file size (%s)", id, err.message);

Should I change the warning outputs of all optional contract fields to debug outputs?

Well, for now, we can let them here. For instance, for the icon one, while it is strictly speaking optional, we do want to force developers to put an icon. Whereas for the max file size, it does not make sense for a lot of contracts (print for instance), so it is really an optional field (and not an optional-if-one-really-is-too-lazy-to-write-it one).