Merge lp://staging/~fisterra-team/fisterra/nitrogen6x-ubuntu-cdimage into lp://staging/~fisterra-team/fisterra/ubuntu-cdimage

Proposed by ethan.hsieh
Status: Needs review
Proposed branch: lp://staging/~fisterra-team/fisterra/nitrogen6x-ubuntu-cdimage
Merge into: lp://staging/~fisterra-team/fisterra/ubuntu-cdimage
Diff against target: 34 lines (+4/-2)
2 files modified
etc/default-arches (+3/-2)
etc/qa-products (+1/-0)
To merge this branch: bzr merge lp://staging/~fisterra-team/fisterra/nitrogen6x-ubuntu-cdimage
Reviewer Review Type Date Requested Status
Steve Langasek (community) Needs Information
Patricia Gaughen Pending
Łukasz Zemczak Pending
ethan.hsieh Pending
Dave Jones Pending
Review via email: mp+375250@code.staging.launchpad.net

This proposal supersedes a proposal from 2019-11-01.

Description of the change

Based on Łukasz's comment, now we only add armhf+imx6 to eoan-.
In the future - once we backport all the required bits into bionic, we add the imx6 subarch to be buildable in bionic.

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Posted in a previous version of this proposal

This is good, one small change proposition in the inline comments.

review: Needs Fixing
Revision history for this message
Steve Langasek (vorlon) : Posted in a previous version of this proposal
review: Needs Fixing
Revision history for this message
Steve Langasek (vorlon) wrote :

Ethan,

Your force-pushing and superseding of MPs is making it difficult to review, here. If you want to flatten your commits at the end once we have agreement about the desired state, that's fine, but in the meantime this makes it very difficult to have a conversation about the changes, and to understand how the new changes you're making are a response to the previous comments.

review: Needs Information
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

On one of the device sync meetings, we agreed that we (foundations) will be responsible for making the changes to cdimage - since this is basically the last thing that needs to be switched for the images to be built. So I guess we can ignore this MP for now.

Unmerged revisions

1818. By ethan.hsieh

Add the imx6-armhf variant to preinstalled server images

1817. By ethan.hsieh

Add the imx6-armhf variant to core18 images

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: