Merge lp://staging/~fginther/ubuntu-ci-services-itself/fix-publish into lp://staging/ubuntu-ci-services-itself
| Status: | Merged |
|---|---|
| Approved by: | Chris Johnston |
| Approved revision: | 382 |
| Merged at revision: | 383 |
| Proposed branch: | lp://staging/~fginther/ubuntu-ci-services-itself/fix-publish |
| Merge into: | lp://staging/ubuntu-ci-services-itself |
| Diff against target: |
49 lines (+14/-15) 2 files modified
lander/bin/lander_service_wrapper.py (+6/-3) ppa-assigner/ppa_assigner/ppa_sync.py (+8/-12) |
| To merge this branch: | bzr merge lp://staging/~fginther/ubuntu-ci-services-itself/fix-publish |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Chris Johnston (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Pass the source packages to the publisher instead of the binary packages and remove the ppa_sync check to not copy if the package is already there.
Description of the change
Pass the source packages to the publisher instead of the binary packages and remove the ppa_sync check to not copy if the package is already there.
It was just an oversight that the binary packages were being copied instead of the source packages. The idea is that everything the user uploaded in the source packages when the ticket was created should get copied into master PPA. The solution is to copy all of the source packages. The binary package list doesn't even accurately reflect that.
This also fixes the problem seen with the publisher. The ppa_sync module expects to operate on source packages, passing it binary packages was the wrong thing to do. This occasionally worked when the source and binary package names were equivalent.
| Francis Ginther (fginther) wrote | # |
| Chris Johnston (cjohnston) | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
http://