Merge lp://staging/~fginther/ubuntu-ci-services-itself/bsbuilder-fixes into lp://staging/ubuntu-ci-services-itself

Proposed by Francis Ginther
Status: Rejected
Rejected by: Andy Doan
Proposed branch: lp://staging/~fginther/ubuntu-ci-services-itself/bsbuilder-fixes
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 819 lines (+449/-97)
11 files modified
branch-source-builder/bsbuilder/resources/v1.py (+2/-2)
branch-source-builder/bsbuilder/run_worker.py (+113/-30)
branch-source-builder/bsbuilder/tests/test_upload.py (+89/-0)
branch-source-builder/bsbuilder/tests/test_v1.py (+2/-2)
branch-source-builder/cupstream2distro/packageinppamanager.py (+4/-7)
branch-source-builder/setup.py (+4/-0)
branch-source-builder/upload_package.py (+47/-35)
branch-source-builder/watch_ppa.py (+163/-8)
juju-deployer/branch-source-builder.yaml.tmpl (+1/-1)
lander/bin/lander_service_wrapper.py (+12/-12)
lander/bin/ticket_api.py (+12/-0)
To merge this branch: bzr merge lp://staging/~fginther/ubuntu-ci-services-itself/bsbuilder-fixes
Reviewer Review Type Date Requested Status
Francis Ginther Needs Fixing
Review via email: mp+210204@code.staging.launchpad.net

Commit message

Pass subtickets directly to the branch source builder, allowing it to create subticket progress updates that are then updated by the lander. Check contents of the PPAs before uploading to ensure that the build will succeed. Create a results file to pass back as a global result artifact and pass a failure status when the build fails.

Description of the change

Pass subtickets directly to the branch source builder, allowing it to create subticket progress updates that are then updated by the lander. Check contents of the PPAs before uploading to ensure that the build will succeed. Create a results file to pass back as a global result artifact and pass a failure status when the build fails.

To post a comment you must log in.
335. By Francis Ginther

Merge to trunk.

336. By Francis Ginther

Merge trunk again.

Revision history for this message
Francis Ginther (fginther) wrote :

Found 2 issues in the result file:
1) mime-type isn't being set.
2) \n, not /n, when joining messages.

review: Needs Fixing
337. By Francis Ginther

Fix content_type and us '\n' instead of '/n' when joining messages.

Revision history for this message
Andy Doan (doanac) wrote :

this was broken up and merged.

Unmerged revisions

337. By Francis Ginther

Fix content_type and us '\n' instead of '/n' when joining messages.

336. By Francis Ginther

Merge trunk again.

335. By Francis Ginther

Merge to trunk.

334. By Francis Ginther

More renaming and a few renaming fixes.

333. By Francis Ginther

Remove _get_versions_for_source_package_in_ppa added to cupstream2distro.

332. By Francis Ginther

Some minor refactoring and renaming.

331. By Francis Ginther

Updates from first round of deployed testing.

330. By Francis Ginther

Pass subtickets directly to the branch source builder, allowing it to create subticket progress updates that are then updated by the lander. Check contents of the PPAs before uploading to ensure that the build will succeed. Create a results file to pass back as a global result artifact.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches