Merge lp://staging/~fginther/ubuntu-ci-services-itself/add-lp-build-logs into lp://staging/ubuntu-ci-services-itself

Proposed by Francis Ginther
Status: Merged
Approved by: Chris Johnston
Approved revision: 373
Merged at revision: 375
Proposed branch: lp://staging/~fginther/ubuntu-ci-services-itself/add-lp-build-logs
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 284 lines (+102/-26)
5 files modified
branch-source-builder/bsbuilder/run_worker.py (+8/-4)
branch-source-builder/bsbuilder/upload_package.py (+8/-5)
branch-source-builder/watch_ppa.py (+56/-9)
lander/bin/lander_service_wrapper.py (+11/-4)
lander/bin/ticket_api.py (+19/-4)
To merge this branch: bzr merge lp://staging/~fginther/ubuntu-ci-services-itself/add-lp-build-logs
Reviewer Review Type Date Requested Status
Chris Johnston (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Andy Doan (community) Approve
Review via email: mp+210668@code.staging.launchpad.net

Commit message

Pass the completed subticket buildlogs to the lander and have it provide subticket status updates.

Description of the change

Pass the completed subticket buildlogs to the lander and have it provide subticket status updates.

The subticket status updates are already being passed back, the just turns on the lander functionality to update the ticket.

Here's a ticket with the subticket artifacts and progress state updates: http://15.125.114.120/ticket.html?ticket_id=6

While testing this, I ran into lp:1291591. I discovered that the check_ppa code which looks for prior uploads was running *after* the upload_source_packages method which does the dput to the ppa. So it's been pure timing luck that we don't see an upload failure on every ticket. I finally hit case where my new source package made it to the ppa before check_ppa executed.

The fix is fairly simply, split upload_packages.upload_source_packages() into two methods, one to crete the upload list, the other to do the dput and then call check_ppa() in between. This was a smaller fix, so I rolled it into here.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:372
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/397/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/397/rebuild

review: Needs Fixing (continuous-integration)
373. By Francis Ginther

Pep8 fix.

Revision history for this message
Andy Doan (doanac) wrote :

yeah!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:373
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/398/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/398/rebuild

review: Approve (continuous-integration)
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches