Merge lp://staging/~fginther/landscape-client/fix-missing-install-dirs into lp://staging/~landscape/landscape-client/trunk

Proposed by Francis Ginther
Status: Merged
Approved by: Francis Ginther
Approved revision: 1008
Merged at revision: 1008
Proposed branch: lp://staging/~fginther/landscape-client/fix-missing-install-dirs
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 34 lines (+7/-5)
3 files modified
debian/landscape-common.dirs (+3/-0)
debian/landscape-common3.dirs (+3/-0)
debian/rules (+1/-5)
To merge this branch: bzr merge lp://staging/~fginther/landscape-client/fix-missing-install-dirs
Reviewer Review Type Date Requested Status
Eric Snow (community) Approve
Andreas Hasenack Approve
🤖 Landscape Builder test results Approve
Review via email: mp+322223@code.staging.launchpad.net

Commit message

Fix missing install directories for landscape-common3 and drop usr/share/landscape as its only used and created by landscape-client.

Description of the change

Fix missing install directories for landscape-common3 and drop usr/share/landscape as its only used and created by landscape-client.

Build a package:
 - dpkg-buildpackage -b -rfakeroot -us -uc

Then install landscape-common3 and landscape-client onto a pristine xenial instance or lxd. The packages should install without error.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make ci-check
Result: Success
Revno: 1008
Branch: lp:~fginther/landscape-client/fix-missing-install-dirs
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3860/

review: Approve (test results)
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

+1, packages built and installed fine, and landscape-client also runs correctly with -common3.

review: Approve
Revision history for this message
Eric Snow (ericsnowcurrently) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: