cupstream2distro Configuration

Merge lp://staging/~fginther/cupstream2distro-config/independent-triggering into lp://staging/cupstream2distro-config

  1. independent-triggering
  2. Merge into trunk
Proposed by Francis Ginther
Status: Merged
Approved by: Francis Ginther
Approved revision: 843
Merged at revision: 844
Proposed branch: lp://staging/~fginther/cupstream2distro-config/independent-triggering
Merge into: lp://staging/cupstream2distro-config
Diff against target: 350 lines (+128/-52)
2 files modified
c2dconfigutils/cu2dTrigger.py (+37/-27)
tests/test_cu2dTrigger.py (+91/-25)
To merge this branch: bzr merge lp://staging/~fginther/cupstream2distro-config/independent-triggering
Reviewer Review Type Date Requested Status
Joe Talbott (community) Approve
Francis Ginther Needs Resubmitting
PS Jenkins bot continuous-integration Approve
Review via email: mp+189953@code.staging.launchpad.net

Commit message

Allow independent triggering of ci and autolanding jobs for entire stacks.

Description of the change

Allow independent triggering of ci and autolanding for entire stacks.

This primarily contains changes to the argument handling to change the behavior of the --trigger-ci and --trigger-autolanding flags. One or both of these is now required to specify the type of jobs to trigger. This was already being done for single branches, now this also applies to stacks.

Here are examples of this in action:
http://10.97.0.26:8080/job/trigger-ci-on-stacks/1/
http://10.97.0.26:8080/job/trigger-autolanding-on-stacks/1/

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:842
http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-ci/547/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-saucy-amd64-ci/345

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/cupstream2distro-config-ci/547/rebuild

review: Approve (continuous-integration)
Revision history for this message
Joe Talbott (joetalbott) wrote :

L97 here trigger_types will either be ['autolanding'] or ['ci'] but in other places I see trigger_types being set to ['autolanding', 'ci']. I might be missing some context.

review: Needs Information
Revision history for this message
Francis Ginther (fginther) wrote :

> L97 here trigger_types will either be ['autolanding'] or ['ci'] but in other
> places I see trigger_types being set to ['autolanding', 'ci']. I might be
> missing some context.

Good catch. This

100 + else:

should be:

if args.trigger_ci:

I want to enable both types of jobs if the arguments are there.

Revision history for this message
Francis Ginther (fginther) :
review: Needs Fixing
lp://staging/~fginther/cupstream2distro-config/independent-triggering updated
843. By Francis Ginther

Should be able to trigger autolanding and ci jobs, not either/or.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:843
http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-ci/548/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/cupstream2distro-config-saucy-amd64-ci/346

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/cupstream2distro-config-ci/548/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) :
review: Needs Resubmitting
Revision history for this message
Joe Talbott (joetalbott) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: