core-image-tester

Merge lp://staging/~fginther/core-image-tester/snappy-queue-updates into lp://staging/~canonical-ci-engineering/core-image-tester/snappy-proposed-migration

  1. snappy-queue-updates
  2. Merge into snappy-proposed-migration
Proposed by Francis Ginther
Status: Merged
Approved by: Francis Ginther
Approved revision: 37
Merged at revision: 36
Proposed branch: lp://staging/~fginther/core-image-tester/snappy-queue-updates
Merge into: lp://staging/~canonical-ci-engineering/core-image-tester/snappy-proposed-migration
Diff against target: 66 lines (+17/-17)
2 files modified
core_image_tester/constants.py (+15/-16)
core_image_tester/tests/test_queue_integration.py (+2/-1)
To merge this branch: bzr merge lp://staging/~fginther/core-image-tester/snappy-queue-updates
Reviewer Review Type Date Requested Status
Paul Larson Approve
Joe Talbott (community) Approve
Review via email: mp+259992@code.staging.launchpad.net

Commit message

Rename queues for snappy-proposed-migration version of core-image-tester.

Description of the change

Rename queues for snappy-proposed-migration version of core-image-tester.

To post a comment you must log in.
lp://staging/~fginther/core-image-tester/snappy-queue-updates updated
37. By Francis Ginther

Use constants for the queue names in the tests too.

Revision history for this message
Joe Talbott (joetalbott) wrote :

LGTM

review: Approve
Revision history for this message
Paul Larson (pwlars) wrote :

One suggestion, but it's not a blocker for me, so +1

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

Paul, thanks for the review. My reasoning for using .format(SOLUTION_NAME) is to make it painfully obvious how the queues are named and hopefully make it easier for anyone copying this code in the future to use it for a new solution.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches