Juju Charms Collection
jenkaas-slave package

Merge lp://staging/~fginther/charms/trusty/jenkaas-slave/update-slave-config into lp://staging/~canonical-ci-engineering/charms/trusty/jenkaas-slave/trunk

  1. Trusty Tahr (14.04)
  2. update-slave-config
  3. Merge into trunk
Proposed by Francis Ginther
Status: Needs review
Proposed branch: lp://staging/~fginther/charms/trusty/jenkaas-slave/update-slave-config
Merge into: lp://staging/~canonical-ci-engineering/charms/trusty/jenkaas-slave/trunk
Diff against target: 46 lines (+14/-2)
2 files modified
hooks/actions.py (+12/-1)
hooks/services.py (+2/-1)
To merge this branch: bzr merge lp://staging/~fginther/charms/trusty/jenkaas-slave/update-slave-config
Reviewer Review Type Date Requested Status
Para Siva (community) Approve
Joe Talbott (community) Approve
Review via email: mp+262619@code.staging.launchpad.net

Commit message

Finish the changes needed to configure a slave via the jenkaas-slave relation.

Description of the change

Finish the changes needed to configure a slave via the jenkaas-slave relation.

This includes passing info on the default user so that the slave can connect without having to enable slave changes via the anonymous user.

To post a comment you must log in.
Revision history for this message
Joe Talbott (joetalbott) wrote :

Looks okay to me.

review: Approve
Reply
Revision history for this message
Para Siva (psivaa) wrote :

+1, looks good to me.

review: Approve
Reply

Unmerged revisions

8. By Francis Ginther

Fix some errors and add the jenkaas-slave-relation-departed hook.

7. By Francis Ginther

Add passing of -jnlpCredentials and remove 'port'.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches