adt-cloud-worker

Merge lp://staging/~fginther/adt-cloud-worker/uci-nova-swapfile into lp://staging/~canonical-ci-engineering/adt-cloud-worker/uci-nova

  1. uci-nova-swapfile
  2. Merge into uci-nova
Proposed by Celso Providelo
Status: Merged
Approved by: Francis Ginther
Approved revision: 13
Merged at revision: 13
Proposed branch: lp://staging/~fginther/adt-cloud-worker/uci-nova-swapfile
Merge into: lp://staging/~canonical-ci-engineering/adt-cloud-worker/uci-nova
Diff against target: 25 lines (+8/-0)
1 file modified
uci-nova (+8/-0)
To merge this branch: bzr merge lp://staging/~fginther/adt-cloud-worker/uci-nova-swapfile
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Thomi Richards (community) Approve
Review via email: mp+257563@code.staging.launchpad.net

Commit message

Add a 4GB swapfile as a way to extend available RAM.

Description of the change

Add a 4GB swapfile as a way to extend available RAM.

To post a comment you must log in.
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

How id this better / worse / different to using the '--swap' option to 'nova boot' ?

review: Needs Information
Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

also, don't forget to set a commit message :D

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

<fginther> thomi, just saw that. I'll comment in both places. --swap only works if the nova flavor is already to configured to have a swap partition.

In that case, this LGTM

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

> How id this better / worse / different to using the '--swap' option to 'nova
> boot' ?

"nova --swap" requires that the nova flavor already have swap configured (this option appears to allow you to specify less then what the flavor specifies). I did try both methods on bootstack and didn't notice any functional differences. Performance may be different but a better testcase first would be helpful.

Revision history for this message
Celso Providelo (cprov) wrote :

Francis,

Thanks for working on this.

As discussed on IRC, it might consume few seconds on the cloud-init setup and 4 GB of disk. Since we recently bumped the disk from 10 to 50 GB, there should be no sensible side-effect on tests that do not need swap.

FTR, that is another change that has no value for core-image-testing.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches