Merge lp://staging/~fginther/adt-cloud-worker/uci-nova-mirror into lp://staging/~canonical-ci-engineering/adt-cloud-worker/uci-nova

Proposed by Francis Ginther
Status: Merged
Approved by: Francis Ginther
Approved revision: 15
Merged at revision: 11
Proposed branch: lp://staging/~fginther/adt-cloud-worker/uci-nova-mirror
Merge into: lp://staging/~canonical-ci-engineering/adt-cloud-worker/uci-nova
Prerequisite: lp://staging/~fginther/adt-cloud-worker/uci-nova-wait-for-active
Diff against target: 73 lines (+25/-3)
1 file modified
uci-nova (+25/-3)
To merge this branch: bzr merge lp://staging/~fginther/adt-cloud-worker/uci-nova-mirror
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Evan Pending
Review via email: mp+257024@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-04-21.

Commit message

Add support for an optional archive mirror and add multiverse if it's specified.

Description of the change

To post a comment you must log in.
Revision history for this message
Evan (ev) wrote : Posted in a previous version of this proposal

I know where the multiverse requirement is coming from, but why do we need this optional archive mirror?

review: Needs Information
Revision history for this message
Francis Ginther (fginther) wrote : Posted in a previous version of this proposal

Added some comments for reviewers.

Revision history for this message
Francis Ginther (fginther) wrote : Posted in a previous version of this proposal

> I know where the multiverse requirement is coming from, but why do we need
> this optional archive mirror?

The existing adt VM tests use ftpmaster.internal as the archive source in order to have access to packages as soon as they are published. Without this, tests end up running against older versions of packages and proposed-migration can't detect this until it gets to britney (and then a manual retry is required). We can't force the use of ftpmaster.internal because it's not publicly available and we want to maintain the ability to use uci-nova in other environments.

Providing --mirror as an option was the only solution I've found so far for satisfying the above.

Revision history for this message
Celso Providelo (cprov) wrote :

Francis,

Thanks for implementing this feature. I agree it's required to be optional because it depends on the environment it's operating, i.e. the same repository used for triggering britney analysis.

Although it seems entirely unfortunate that instead of dealing with possible/transient inconsistencies (needs to test version X, but it's not available, will retry later) the adt-jenkins system relies on external arrangements to make sure it never happens (internal mirrors, apt-caches, extra load on ftpmaster, etc).

I think we can do a lot better, if we start requesting and monitoring tests in adt-cloud direct from britney (I don't mean direct amqp access as uci-britney, but instead the synchronous rest api we already have).

That said, let's see how the uci-nova workaround performs in production.

review: Approve
Revision history for this message
Francis Ginther (fginther) wrote :

Celso,

I fully agree. During the Austin sprint, cjwatson and jibel mentioned that there is an alternate means to ensure that a testbed has the correct version of the archive by comparing timestamps. But there is additional work in other parts of the proposed-migration process to make this functional. I believing 'fixing' that problem is outside the scope of what we need to accomplish for this story. But it should be part of a more thorough update when the time comes.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches