Linaro Android Bot Review

Merge lp://staging/~fgiff/linaro-android-bot-review/ignore-dead-builds into lp://staging/linaro-android-bot-review

  1. ignore-dead-builds
  2. Merge into trunk
Proposed by Frans Gifford
Status: Merged
Merged at revision: 80
Proposed branch: lp://staging/~fgiff/linaro-android-bot-review/ignore-dead-builds
Merge into: lp://staging/linaro-android-bot-review
Diff against target: 51 lines (+18/-4)
2 files modified
androidbotreview.py (+3/-2)
jenkinsconnection.py (+15/-2)
To merge this branch: bzr merge lp://staging/~fgiff/linaro-android-bot-review/ignore-dead-builds
Reviewer Review Type Date Requested Status
Bernhard Rosenkraenzer Approve
Linaro Android Bot Maintainers Pending
Review via email: mp+84976@code.staging.launchpad.net

Description of the change

This prevents the bot from failing in the case that the a build has been garbage collected from Jenkins. Such a case is uncommon in normal usage, but can occur when testing against old changesets.

To post a comment you must log in.
Revision history for this message
Bernhard Rosenkraenzer (berolinux) wrote :

Looks good to me, but I don't think I have the privileges to approve this

review: Approve
Revision history for this message
Frans Gifford (fgiff) wrote :

> Looks good to me, but I don't think I have the privileges to approve this

Right, I'll merge it myself and fix the group privileges.

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Please don't forget to request this to be deployed (via ticket).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: