Merge lp://staging/~fgallina/rnr-server/reviewsapp-to-core-cleanups into lp://staging/rnr-server
Proposed by
Fabián Ezequiel Gallina
| Status: | Merged |
|---|---|
| Approved by: | Fabián Ezequiel Gallina |
| Approved revision: | 280 |
| Merged at revision: | 277 |
| Proposed branch: | lp://staging/~fgallina/rnr-server/reviewsapp-to-core-cleanups |
| Merge into: | lp://staging/rnr-server |
| Diff against target: |
1392 lines (+557/-554) 15 files modified
fabtasks/django.py (+1/-1) src/clickreviews/models.py (+2/-4) src/core/models.py (+39/-0) src/core/tests/test_utilities.py (+303/-0) src/core/utilities.py (+190/-0) src/reviewsapp/auth.py (+1/-1) src/reviewsapp/forms.py (+1/-1) src/reviewsapp/models.py (+1/-39) src/reviewsapp/preflight.py (+1/-1) src/reviewsapp/tests/factory.py (+1/-6) src/reviewsapp/tests/test_auth.py (+1/-1) src/reviewsapp/tests/test_handlers.py (+2/-2) src/reviewsapp/tests/test_utilities.py (+1/-299) src/reviewsapp/tests/test_wsgi.py (+8/-13) src/reviewsapp/utilities.py (+5/-186) |
| To merge this branch: | bzr merge lp://staging/~fgallina/rnr-server/reviewsapp-to-core-cleanups |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ricardo Kirkner (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Split `reviewsapp.
The new now `core.utilities` module includes `WebService` related code
together with `full_claimed`; leaving just `reviewsapp` used code in
`reviewsapp.
Description of the change
Cleanups moving globally used code from `reviewsapp` to the `core` app
so neither of `clickreviews` or `core` apps depend on `reviewsapp`.
This preliminary cleanup serves as first step for moving API auth
currently in `reviewsapp.auth` to `core` and then be able to reuse
some of its code in the new authentication implementation that's
coming.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM