Ratings and Reviews server

Merge lp://staging/~fgallina/rnr-server/oauth-cleanup into lp://staging/rnr-server

oauth-cleanup
Merge into trunk

Proposed by Fabián Ezequiel Gallina on 2014-08-06

Status:	Merged
Approved by:	Fabián Ezequiel Gallina on 2014-08-08
Approved revision:	263
Merged at revision:	266
Proposed branch:	lp://staging/~fgallina/rnr-server/oauth-cleanup
Merge into:	lp://staging/rnr-server
Diff against target:	946 lines (+278/-390) 10 files modified django_project/config/main.cfg (+1/-3) src/clickreviews/models.py (+1/-1) src/reviewsapp/admin.py (+0/-8) src/reviewsapp/migrations/0017_auto__del_consumer__del_token__del_nonce.py (+187/-0) src/reviewsapp/models/__init__.py (+0/-50) src/reviewsapp/models/oauthtoken.py (+0/-212) src/reviewsapp/schema.py (+0/-4) src/reviewsapp/tests/factory.py (+26/-45) src/reviewsapp/tests/test_auth.py (+62/-66) src/reviewsapp/tests/test_middleware.py (+1/-1)
To merge this branch:	bzr merge lp://staging/~fgallina/rnr-server/oauth-cleanup
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Natalia Bidart (community)		2014-08-06	Approve on 2014-08-07
Review via email: mp+229854@code.staging.launchpad.net

Commit message

Removed oauthtoken models

Revision history for this message

Natalia Bidart (nataliabidart) wrote on 2014-08-07:

Overall looks good!

I would advice running flakes8 just in case some unwanted imports are left, suggested command is:

flake8 src/ | /bin/grep -v migrations

lp://staging/~fgallina/rnr-server/oauth-cleanup updated on 2014-08-07

263. By Fabián Ezequiel Gallina on 2014-08-07: Let oauth_data_store setting be handled by piston

Revision history for this message

Natalia Bidart (nataliabidart) wrote on 2014-08-07:

14:09 < fgallina> nessita: there are several flake8 warnings spread, so I'll create a separate branch for those. Just pushed the oauth_data_store removal.
14:57 < nessita> fgallina, ack!

review: Approve