Merge lp://staging/~fgallina/rnr-server/no-query-string-to-sso into lp://staging/rnr-server
Proposed by
Fabián Ezequiel Gallina
| Status: | Merged |
|---|---|
| Approved by: | Natalia Bidart |
| Approved revision: | 311 |
| Merged at revision: | 309 |
| Proposed branch: | lp://staging/~fgallina/rnr-server/no-query-string-to-sso |
| Merge into: | lp://staging/rnr-server |
| Diff against target: |
237 lines (+88/-21) 2 files modified
src/core/api/auth/sso.py (+20/-10) src/core/tests/test_api_auth.py (+68/-11) |
| To merge this branch: | bzr merge lp://staging/~fgallina/rnr-server/no-query-string-to-sso |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Natalia Bidart (community) | Approve | ||
|
Review via email:
|
|||
Commit message
SSO auth enhancements
- do not use query_string as it's already present in the URL
- Backport checks for deciding if a request as oauth bits or not.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
15:16 < nessita> fgallina, looks good, a nitpick is that you should have a added a couple of new tests to ensure the semantic of if not has_oauth_