Merge lp://staging/~fgallina/rnr-server/move-reviewsapp-api-auth-to-core into lp://staging/rnr-server
Proposed by
Fabián Ezequiel Gallina
| Status: | Merged |
|---|---|
| Approved by: | Fabián Ezequiel Gallina |
| Approved revision: | 284 |
| Merged at revision: | 278 |
| Proposed branch: | lp://staging/~fgallina/rnr-server/move-reviewsapp-api-auth-to-core |
| Merge into: | lp://staging/rnr-server |
| Prerequisite: | lp://staging/~fgallina/rnr-server/reviewsapp-to-core-cleanups |
| Diff against target: |
1113 lines (+413/-384) 13 files modified
src/clickreviews/api/urls.py (+1/-1) src/clickreviews/tests/factory.py (+10/-1) src/clickreviews/tests/test_handlers.py (+4/-4) src/core/api/auth/__init__.py (+6/-0) src/core/api/auth/sso.py (+1/-101) src/core/tests/factory.py (+101/-0) src/core/tests/test_api_auth.py (+27/-174) src/core/tests/test_utilities.py (+148/-0) src/core/utilities.py (+98/-1) src/reviewsapp/api/urls.py (+1/-1) src/reviewsapp/tests/factory.py (+4/-93) src/reviewsapp/tests/test_handlers.py (+2/-2) src/reviewsapp/tests/test_rnrclient.py (+10/-6) |
| To merge this branch: | bzr merge lp://staging/~fgallina/rnr-server/move-reviewsapp-api-auth-to-core |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ricardo Kirkner (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Move `reviewsapp.auth` logic into `core.api.auth`
Split auth logic so that it is re-usable by other auth mechanisms.
Incidentally, this also makes a good deal moving forward to the
separation of `reviewsapp` and `clickreviews`.
Description of the change
Split auth logic so that is re-usable by the new auth mechanism.
Incidentally, this also makes a good deal moving forward to the
separation of `reviewsapp` and `clickreviews`.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM