Merge lp://staging/~fgallina/rnr-server/make-piston-raise-not-return into lp://staging/rnr-server
Proposed by
Fabián Ezequiel Gallina
| Status: | Merged |
|---|---|
| Approved by: | Fabián Ezequiel Gallina |
| Approved revision: | 275 |
| Merged at revision: | 275 |
| Proposed branch: | lp://staging/~fgallina/rnr-server/make-piston-raise-not-return |
| Merge into: | lp://staging/rnr-server |
| Diff against target: |
29 lines (+9/-0) 2 files modified
django_project/config/main.cfg (+4/-0) src/reviewsapp/schema.py (+5/-0) |
| To merge this branch: | bzr merge lp://staging/~fgallina/rnr-server/make-piston-raise-not-return |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Natalia Bidart (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Make piston raise exceptions so OOPSes can report it
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
(09:25:18 AM) nessita: fgallina: question, why setting the default to True and then to False in main.cfg?
(09:26:02 AM) fgallina: nessita: because those are the real defaults and I wanted to be explicit about that.
(09:26:13 AM) nessita: fgallina: ack, approving
(09:26:21 AM) fgallina: k, thanks.