Merge lp://staging/~fgallina/rnr-server/flake8-cleanups into lp://staging/rnr-server

Proposed by Fabián Ezequiel Gallina
Status: Merged
Approved by: Fabián Ezequiel Gallina
Approved revision: 267
Merged at revision: 267
Proposed branch: lp://staging/~fgallina/rnr-server/flake8-cleanups
Merge into: lp://staging/rnr-server
Diff against target: 387 lines (+45/-69)
14 files modified
src/clickreviews/api/handlers.py (+2/-4)
src/clickreviews/forms.py (+0/-1)
src/clickreviews/tests/factory.py (+1/-2)
src/clickreviews/tests/test_forms.py (+18/-24)
src/reviewsapp/api/handlers.py (+1/-0)
src/reviewsapp/forms.py (+0/-1)
src/reviewsapp/schema.py (+0/-1)
src/reviewsapp/tests/helpers.py (+2/-5)
src/reviewsapp/tests/test_command_update_stats.py (+2/-2)
src/reviewsapp/tests/test_handlers.py (+9/-8)
src/reviewsapp/tests/test_middleware.py (+0/-8)
src/reviewsapp/tests/test_models.py (+8/-9)
src/reviewsapp/tests/test_views.py (+1/-3)
src/reviewsapp/utilities.py (+1/-1)
To merge this branch: bzr merge lp://staging/~fgallina/rnr-server/flake8-cleanups
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Review via email: mp+230107@code.staging.launchpad.net

Commit message

Cleanup all flake8 warnings

Also modify clickreviews.tests.test_forms to use TestCaseWithFactory

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches