Merge lp://staging/~fgallina/rnr-server/emitter-cleanup into lp://staging/rnr-server
Proposed by
Fabián Ezequiel Gallina
| Status: | Merged |
|---|---|
| Approved by: | Fabián Ezequiel Gallina |
| Approved revision: | 268 |
| Merged at revision: | 268 |
| Proposed branch: | lp://staging/~fgallina/rnr-server/emitter-cleanup |
| Merge into: | lp://staging/rnr-server |
| Diff against target: |
118 lines (+85/-2) 1 file modified
src/reviewsapp/tests/test_handlers.py (+85/-2) |
| To merge this branch: | bzr merge lp://staging/~fgallina/rnr-server/emitter-cleanup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Natalia Bidart (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Added tests for Django13JSONEmitter
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
15:01 < nessita> fgallina, are we still using Django13JSONEncoder in the live code? (the "13" part worries me)
15:02 < fgallina> nessita: yes, well... the "13" could be removed. The truth is that what it does really is to set explicitly the way dates should be formatted, other than that there's no other compatibility thing.
15:03 < nessita> looks good, +1