Merge lp://staging/~fgallina/rnr-server/decouple-moderation-models into lp://staging/rnr-server

Proposed by Fabián Ezequiel Gallina
Status: Merged
Approved by: Fabián Ezequiel Gallina
Approved revision: 271
Merged at revision: 271
Proposed branch: lp://staging/~fgallina/rnr-server/decouple-moderation-models
Merge into: lp://staging/rnr-server
Diff against target: 406 lines (+172/-115)
6 files modified
django_project/config/main.cfg (+1/-0)
src/clickreviews/models.py (+0/-9)
src/core/models.py (+140/-0)
src/reviewsapp/models.py (+25/-101)
src/reviewsapp/tests/test_middleware.py (+1/-1)
src/reviewsapp/tests/test_models.py (+5/-4)
To merge this branch: bzr merge lp://staging/~fgallina/rnr-server/decouple-moderation-models
Reviewer Review Type Date Requested Status
Michael Nelson (community) Approve
Review via email: mp+230888@code.staging.launchpad.net

Commit message

Decoupled Moderation features from reviewsapp.ReviewModeration

This adds a new core app that will eventually hold all common
functionality between reviewsapp and clickreviews so that
interpendence of these two will be removed.

Description of the change

Decouple of moderation models, initial steps to independence for reviewsapp and clickreviews

To post a comment you must log in.
Revision history for this message
Fabián Ezequiel Gallina (fgallina) wrote :

Decoupled moderation/flagging features from reviewsapp

This adds a new core app that will eventually hold all common
functionality between reviewsapp and clickreviews so that
interpendence of these two will be removed.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Excellent - thanks Fabián!

review: Approve
Revision history for this message
Michael Nelson (michael.nelson) wrote :

It'd be nice if we had namespaced packages (rather than import core), if it wasn't difficult, but +1 either way.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches