Merge lp://staging/~fgallina/rnr-server/config-enhancements into lp://staging/rnr-server

Proposed by Fabián Ezequiel Gallina
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: 273
Merged at revision: 259
Proposed branch: lp://staging/~fgallina/rnr-server/config-enhancements
Merge into: lp://staging/rnr-server
Prerequisite: lp://staging/~fgallina/rnr-server/dependencies-enhancements
Diff against target: 425 lines (+160/-145)
6 files modified
django_project/config/devel.cfg (+64/-0)
django_project/config/logging.conf (+0/-27)
django_project/config/main.cfg (+80/-106)
django_project/paths.py (+7/-3)
django_project/wsgi.py (+9/-5)
src/reviewsapp/schema.py (+0/-4)
To merge this branch: bzr merge lp://staging/~fgallina/rnr-server/config-enhancements
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Review via email: mp+229617@code.staging.launchpad.net

Commit message

Simplified configuration and wsgi startup

This joins several non-sensitive defaults found in the main.cfg of the rnr-config branch, plus simplification of the logging setup to use Django's built-in machinery via the LOGGING settings.

Also the project's wsgi.py has been reworked to include relevant parts of the rnr-config branch, plus to include the path setup so sourcedeps and custom apps are recognized out of the box without effort.

At last, but not least, overriding the current settings via CONFIGGLUE_LOCAL_CONFIG is now enabled in order to get rid of the custom manage_schema_changes.py script.

Description of the change

Work towards the simplification and upgrade of RnR setup

This joins several non-sensitive defaults found in the main.cfg of the rnr-config branch, plus simplification of the logging setup to use Django's built-in machinery via the LOGGING settings.

Also the project's wsgi.py has been reworked to include relevant parts of the rnr-config branch, plus to include the path setup so sourcedeps and custom apps are recognized out of the box without effort.

At last, but not least, overriding the current settings via CONFIGGLUE_LOCAL_CONFIG is now enabled in order to get rid of the custom manage_schema_changes.py script.

To post a comment you must log in.
269. By Fabián Ezequiel Gallina

Fixed paths.py imports conflict

270. By Fabián Ezequiel Gallina

Merged dependencies-enhancements into config-enhancements.

271. By Fabián Ezequiel Gallina

Merge dependencies-enhancements, fix tarmac_verify.sh conflict

272. By Fabián Ezequiel Gallina

Merged dependencies-enhancements into config-enhancements.

Revision history for this message
Ricardo Kirkner (ricardokirkner) :
Revision history for this message
Fabián Ezequiel Gallina (fgallina) :
273. By Fabián Ezequiel Gallina

Re-add comment for cache_review_stats_seconds setting

Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches