Merge lp://staging/~fgallina/rnr-server/clickpackage-flagging into lp://staging/rnr-server

Proposed by Fabián Ezequiel Gallina
Status: Merged
Approved by: Fabián Ezequiel Gallina
Approved revision: 279
Merged at revision: 272
Proposed branch: lp://staging/~fgallina/rnr-server/clickpackage-flagging
Merge into: lp://staging/rnr-server
Prerequisite: lp://staging/~fgallina/rnr-server/decouple-moderation-models
Diff against target: 1366 lines (+1194/-22)
9 files modified
src/clickreviews/api/handlers.py (+44/-9)
src/clickreviews/api/urls.py (+23/-1)
src/clickreviews/forms.py (+113/-0)
src/clickreviews/migrations/0002_auto__add_clickpackagereviewflag__add_clickpackagemoderation__add_clic.py (+182/-0)
src/clickreviews/models.py (+86/-0)
src/clickreviews/tests/factory.py (+52/-5)
src/clickreviews/tests/test_forms.py (+257/-2)
src/clickreviews/tests/test_handlers.py (+183/-1)
src/clickreviews/tests/test_models.py (+254/-4)
To merge this branch: bzr merge lp://staging/~fgallina/rnr-server/clickpackage-flagging
Reviewer Review Type Date Requested Status
Matias Bordese (community) Approve
Review via email: mp+230887@code.staging.launchpad.net

Commit message

Implementation of flagging for click reviews and packages

This is the initial implementation for click packages and click
package reviews flagging. The implementation differs from what's
found in reviewsapp, as all validation logic is provided via forms.

Current handlers allow for flagging packages or reviews, and a same
user cannot flag the same object twice.

Description of the change

Implementation of click package and click package review flagging

To post a comment you must log in.
Revision history for this message
Matias Bordese (matiasb) wrote :

Added comments.

275. By Fabián Ezequiel Gallina

Tests cleanup

276. By Fabián Ezequiel Gallina

Fix clickreview 0002 migration DateTimeField defaults

277. By Fabián Ezequiel Gallina

Add translations for click flag forms error messages

278. By Fabián Ezequiel Gallina

Cleanup useless transaction.atomic calls and use get_or_create

Revision history for this message
Fabián Ezequiel Gallina (fgallina) wrote :

replied inline comments

279. By Fabián Ezequiel Gallina

Inject __name__ to clickreviews flag resources to avoid attribute errors

Revision history for this message
Matias Bordese (matiasb) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches