Merge lp://staging/~fgallina/ols-store-tests/register-name-window-updates into lp://staging/~ubuntuone-pqm-team/ols-store-tests/store-acceptance-tests

Proposed by Fabián Ezequiel Gallina
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 43
Merged at revision: 39
Proposed branch: lp://staging/~fgallina/ols-store-tests/register-name-window-updates
Merge into: lp://staging/~ubuntuone-pqm-team/ols-store-tests/store-acceptance-tests
Diff against target: 334 lines (+112/-68)
11 files modified
.bzrignore (+1/-1)
Makefile (+2/-22)
README (+23/-0)
dependencies.txt (+1/-0)
ols-vms.conf (+0/-8)
run-landing-tests.sh (+9/-0)
setup-dev-env (+0/-10)
tests/api/cpi/test_package.py (+1/-1)
tests/api/cpi/test_snaps.py (+1/-1)
tests/api/snap/test_register_name.py (+66/-22)
tests/api/snap/test_snap_release.py (+8/-3)
To merge this branch: bzr merge lp://staging/~fgallina/ols-store-tests/register-name-window-updates
Reviewer Review Type Date Requested Status
Fabián Ezequiel Gallina (community) Approve
Matias Bordese (community) Approve
Review via email: mp+318464@code.staging.launchpad.net

Commit message

Update store acceptance tests for name registration

To post a comment you must log in.
Revision history for this message
Matias Bordese (matiasb) wrote :

Looks good, but I have a question.

Revision history for this message
Fabián Ezequiel Gallina (fgallina) :
Revision history for this message
Matias Bordese (matiasb) :
review: Approve
Revision history for this message
Matias Bordese (matiasb) wrote :

LGTM, thanks

review: Approve
Revision history for this message
Fabián Ezequiel Gallina (fgallina) wrote :

LGTM, last commit from a separate already approved branch to enable landings once again.

review: Approve
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :
Revision history for this message
Otto Co-Pilot (otto-copilot) wrote :
Revision history for this message
Vincent Ladeuil (vila) wrote :

18:01:58 E: ======================================================================
18:01:58 E: ERROR: test_create_customer_success (snap.test_snap_purchases_customers.CreateCustomerTestCase)
18:01:58 E: ----------------------------------------------------------------------
18:01:58 E: (Network error: ProxyError: HTTPSConnectionPool(host='api.stripe.com', port=443): Max retries exceeded with url: /v1/tokens (Caused by ProxyError('Cannot connect to proxy.', OSError('Tunnel connection failed: 403 Forbidden',))))

should be fixed by https://code.launchpad.net/~vila/canonical-is-puppet/jaas_ols_slaves-to-api_stripe_com/+merge/318731

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches