Ubuntu
casper package

Merge lp://staging/~fernandezm/ubuntu/utopic/casper/toram-casper into lp://staging/ubuntu/utopic/casper

  1. Utopic (14.10)
  2. toram-casper
  3. Merge into utopic
Proposed by Marcelo Fernandez
Status: Needs review
Proposed branch: lp://staging/~fernandezm/ubuntu/utopic/casper/toram-casper
Merge into: lp://staging/ubuntu/utopic/casper
Diff against target: 85 lines (+50/-3)
2 files modified
debian/changelog (+14/-0)
scripts/casper (+36/-3)
To merge this branch: bzr merge lp://staging/~fernandezm/ubuntu/utopic/casper/toram-casper
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Needs Fixing
Review via email: mp+219078@code.staging.launchpad.net

Description of the change

Adding a new cmdline parameter called 'toram-casper', which allows to copy just one casper directory to RAM when using toram option. This is useful when you have multiple casper directories in your media, supporting different squashfs environments (i.e., to support different hardware in the same ISO).

For example, look at this isolinux.cfg:

LABEL platform1
  kernel /casper_platform1/vmlinuz
  append file=/cdrom/preseed/ubuntu.seed boot=casper initrd=/casper_platform1/initrd.lz live-media-path=/casper_platform1 toram toram-casper=casper_platform1
LABEL platform2
  kernel /casper_platform2/vmlinuz
  append file=/cdrom/preseed/ubuntu.seed boot=casper initrd=/casper_platform2/initrd.lz live-media-path=/casper_platform2 toram toram-casper=casper_platform2

With this patch, casper will copy to the system RAM only the adequate "casper_platform" directory and not everything in the media. This is useful when you have a 4GB DVD ISO with different "casper_platform" directories and you have a 1GB RAM machine.

To post a comment you must log in.
Revision history for this message
Luke Yelavich (themuso) wrote :

Thanks for your work.
I am not currently in a position to test this fix to make sure it still works in all use cases, but code wise it looks ok. I would ask that you add a debian/changelog entry, and explain clearly what this change is, and why it is being made, i.e something similar to what you wrote in the merge proposal message. Your bzr log message could be used, but it is not detailed enough as to the change, and why it is being made.

Thanks again.

review: Needs Fixing
Reply
lp://staging/~fernandezm/ubuntu/utopic/casper/toram-casper updated
1137. By Marcelo Fernandez

Adding debian/changelog.

Revision history for this message
Marcelo Fernandez (fernandezm) wrote :

Thanks Luke, now I've pushed the debian/changelog entry, I hope it gets merged. :-)

Let me know if there's anything else left to do.

Regards

Reply

Unmerged revisions

1137. By Marcelo Fernandez

Adding debian/changelog.

1136. By Marcelo Fernandez

Added toram-casper cmdline option to copy only one casper directory (not everything) from the media to RAM

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches