Merge lp://staging/~feng-kylin/unity8/adjustColorToHighlightingIndicator into lp://staging/unity8

Proposed by handsome_feng
Status: Merged
Approved by: Nick Dedekind
Approved revision: 1901
Merged at revision: 1914
Proposed branch: lp://staging/~feng-kylin/unity8/adjustColorToHighlightingIndicator
Merge into: lp://staging/unity8
Diff against target: 84 lines (+17/-17)
4 files modified
qml/Panel/IndicatorItem.qml (+3/-3)
qml/Panel/IndicatorItemRow.qml (+1/-1)
qml/Panel/IndicatorsBar.qml (+1/-1)
tests/qmltests/Panel/tst_IndicatorItem.qml (+12/-12)
To merge this branch: bzr merge lp://staging/~feng-kylin/unity8/adjustColorToHighlightingIndicator
Reviewer Review Type Date Requested Status
Nick Dedekind (community) Approve
Unity Team Pending
Review via email: mp+266837@code.staging.launchpad.net

Commit message

Adjust the color to highlighting indicator.

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.

no

 * Did you perform an exploratory manual test run of your code change and any related functionality?

yes

 * Did you make sure that your branch does not contain spurious tags?

yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

n/a

 * If you changed the UI, has there been a design review?

no

To post a comment you must log in.
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass? If not, please explain why.
Has not run

 * Did you make sure that the branch does not contain spurious tags?
Tags in trunk.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches