Merge lp://staging/~feng-kylin/unity8/AddSmallDropShadowOnText into lp://staging/unity8
| Status: | Rejected |
|---|---|
| Rejected by: | Albert Astals Cid |
| Proposed branch: | lp://staging/~feng-kylin/unity8/AddSmallDropShadowOnText |
| Merge into: | lp://staging/unity8 |
| Diff against target: |
415 lines (+145/-27) 10 files modified
qml/Components/DelayedLockscreen.qml (+21/-8) qml/Components/DropShadowText.qml (+48/-0) qml/Components/Lockscreen.qml (+10/-1) qml/Components/PassphraseLockscreen.qml (+19/-5) qml/Components/PinLockscreen.qml (+29/-6) qml/Components/PinPadButton.qml (+11/-1) qml/Greeter/Clock.qml (+3/-2) qml/Greeter/CoverPage.qml (+1/-1) qml/Greeter/Infographics.qml (+1/-1) qml/Greeter/LoginList.qml (+2/-2) |
| To merge this branch: | bzr merge lp://staging/~feng-kylin/unity8/AddSmallDropShadowOnText |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Zanetti (community) | Needs Fixing | ||
| Jouni Helminen | Pending | ||
|
Review via email:
|
|||
Commit message
Added a small drop shadow on the text on the Greeter and the Lockscreens.
Description of the change
Added a small drop shadow on the text on the Greeter and the Lockscreens to keep fonts readable wherever we allow the user setting his own background image.
* Are there any related MPs required for this MP to build/function as expected? Please list.
no
* Did you perform an exploratory manual test run of your code change and any related functionality?
yes
* Did you make sure that your branch does not contain spurious tags?
yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
* If you changed the UI, has there been a design review?
no
| handsome_feng (feng-kylin) wrote | # |
| Michael Zanetti (mzanetti) wrote | # |
| Albert Astals Cid (aacid) wrote | # |
Unmerged revisions
- 1796. By handsome_feng
-
merge trunk
- 1795. By handsome_feng
-
Modified the anchors statements
- 1794. By handsome_feng
-
Added the drop shadow on the icons
- 1793. By handsome_feng
-
Add a small drop shadow on the text
There are some elements missing:
* The dots that appear when pressing a number
* The backspace button
* the close/cancel button
* The phone icon next to "Emergency call"
===
The checklist is missing
===
Also I'd like to have a review from design. I'll try to get hold of a designer.